[#86] 토스트 구현 #88
Merged
[#86] 토스트 구현 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ToastView 추가해 레이아웃 구현 - 테스트 코드 한 뷰에서 작업
- 뷰와 테스트뷰, 모델을 분리
Closed
2 tasks
zaehorang
reviewed
Nov 20, 2024
There was a problem hiding this comment.
message 프로퍼티의 타입을 옵셔널로 선언하고
hideToast 메서드에서 로직이 끝나면 nil 값을 할당해주는 이유가 있을까요?
isVisible 프로퍼티로만 토스트를 온/오프 하고 있다고 생각이 들어서 질문 남깁니다.
There was a problem hiding this comment.
토스트가 비활성화될 때 더이상 표시할 메시지가 없다는 명시적인 상태를 나타내려고 했던 것 같아요. 지금 다시 보니 굳이 nil로 표시하지 않아도 된다고 판단되네요 수정하겠습니당 ~
- nil 대신 기본값을 빈 문자열로 설정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)